User traits editor UI #42620
Merged
User traits editor UI #42620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghermit
commented
Jun 10, 2024
|
How the editor UI looks: |
r0mant
approved these changes
Jun 12, 2024
kimlisa
reviewed
Jun 13, 2024
web/packages/teleport/src/Users/UserAddEdit/TraitsEditor.test.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Users/UserAddEdit/TraitsEditor.test.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Users/UserAddEdit/TraitsEditor.test.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Users/UserAddEdit/TraitsEditor.test.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Users/UserAddEdit/TraitsEditor.test.tsx
Outdated
Show resolved
Hide resolved
- remove double type declaration - move traitsToTraitsOption to be used as default value in setConfiguredTraits - label copy update - udpate test
…scrollbar appears
kimlisa
approved these changes
Jun 13, 2024
kimlisa
reviewed
Jun 13, 2024
kimlisa
approved these changes
Jun 14, 2024
|
@flyinghermit See the table below for backport results.
|
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add, edit or delete user traits from Web UI.
changelog: Added ability to edit user traits from Web UI.