Remove Assist #42657
Merged
Remove Assist #42657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato,
xinding33 and
zmb3
rosstimothy
approved these changes
Jun 7, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
marcoandredinis,
mmcallister,
zmb3,
hugoShaka,
xinding33 and
ptgott
|
Can we get rid of |
@zmb3 I removed it as well (and all related code) |
jakule
force-pushed
the
jakule/remove-assist-impl
branch
from
511d1de to
02ede86
Compare
zmb3
reviewed
Jun 10, 2024
e
Outdated
jakule
force-pushed
the
jakule/remove-assist-impl
branch
from
02ede86 to
3f87482
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
GavinFrazar
reviewed
Jun 18, 2024
Comment on lines
-809
to
-811
| // Assist is a set of options related to the Teleport Assist feature. | ||
| Assist *AuthAssistOptions `yaml:"assist,omitempty"` | ||
|
|
There was a problem hiding this comment.
@jakule this will break teleport startup after upgrade if the field is set with a message like
ERROR: failed parsing the config file: yaml: unmarshal errors: line 41: field assist not found in type config.Auth
Which I just hit trying to patch my staging tenant.
And we still document that field in both auth and proxy service config reference:
https://goteleport.com/docs/reference/config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Teleport Assist has been removed