Improve recording upload backoff #42718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/recording_backoff
branch
from
3672a0b to
daf1d9a
Compare
github-actions
bot
added
audit-log
zmb3
approved these changes
Jun 10, 2024
AntonAM
approved these changes
Jun 11, 2024
public-teleport-github-review-bot
bot
removed the request for review
from espadolini
espadolini
approved these changes
Jun 11, 2024
rosstimothy
force-pushed
the
tross/recording_backoff
branch
from
daf1d9a to
54201a7
Compare
rosstimothy
force-pushed
the
tross/recording_backoff
branch
2 times, most recently
from
ef66eee to
2c49420
Compare
Failed uploads could get in an infinite backoff of 10s instead of linearly backing off as intended. Due to the asynchronous nature of launching uploads by `(Uploader) Scan`, it could return without an error which resulted in resetting the backoff to its initial value even if previous failed uploads had incremented the backoff. To avoid this, resetting the backoff delay was modified to only occur if an upload completed successfully. Additionally error messaging was attempted to be improved. Any errors caused by the stream being terminated should now be returned instead of a vague message.
rosstimothy
force-pushed
the
tross/recording_backoff
branch
from
2c49420 to
83b9045
Compare
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Jun 11, 2024
Failed uploads could get in an infinite backoff of 10s instead of linearly backing off as intended. Due to the asynchronous nature of launching uploads by `(Uploader) Scan`, it could return without an error which resulted in resetting the backoff to its initial value even if previous failed uploads had incremented the backoff. To avoid this, resetting the backoff delay was modified to only occur if an upload completed successfully. Additionally error messaging was attempted to be improved. Any errors caused by the stream being terminated should now be returned instead of a vague message.
rosstimothy
added a commit
that referenced
this pull request
Jun 11, 2024
Failed uploads could get in an infinite backoff of 10s instead of linearly backing off as intended. Due to the asynchronous nature of launching uploads by `(Uploader) Scan`, it could return without an error which resulted in resetting the backoff to its initial value even if previous failed uploads had incremented the backoff. To avoid this, resetting the backoff delay was modified to only occur if an upload completed successfully. Additionally error messaging was attempted to be improved. Any errors caused by the stream being terminated should now be returned instead of a vague message.
This was referenced Jun 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Failed uploads could get in an infinite backoff of 10s instead of linearly backing off as intended. Due to the asynchronous nature of launching uploads by `(Uploader) Scan`, it could return without an error which resulted in resetting the backoff to its initial value even if previous failed uploads had incremented the backoff. To avoid this, resetting the backoff delay was modified to only occur if an upload completed successfully. Additionally error messaging was attempted to be improved. Any errors caused by the stream being terminated should now be returned instead of a vague message.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Failed uploads could get in an infinite backoff of 10s instead of linearly backing off as intended. Due to the asynchronous nature of launching uploads by `(Uploader) Scan`, it could return without an error which resulted in resetting the backoff to its initial value even if previous failed uploads had incremented the backoff. To avoid this, resetting the backoff delay was modified to only occur if an upload completed successfully. Additionally error messaging was attempted to be improved. Any errors caused by the stream being terminated should now be returned instead of a vague message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed uploads could get in an infinite backoff of 10s instead of linearly backing off as intended. Due to the asynchronous nature of launching uploads by
(Uploader) Scan, it could return without an error which resulted in resetting the backoff to its initial value even if previous failed uploads had incremented the backoff. To avoid this, resetting the backoff delay was modified to only occur if an upload completed successfully.Additionally error messaging was attempted to be improved. Any errors caused by the stream being terminated should now be returned instead of a vague message.
changelog: Improve backoff of session recording uploads by teleport agents