Fix TestInitDatabaseService/enabled_invalid_databases flakiness
#43196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
gabrielcorado
added
the
no-changelog
avatus
approved these changes
Jun 18, 2024
greedy52
approved these changes
Jun 18, 2024
public-teleport-github-review-bot
bot
removed the request for review
from fheinecke
|
@gabrielcorado See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix test flakiness introduced at #42900. Related to #42963.
The flakiness on
TestInitDatabaseService/enabled_invalid_databaseswas caused by the low timeout used while waiting for the service to exit. This value was set to low because tests that don't exit with an error would always require exceeding this timeout (causing a failure on the "Flaky Tests Detector" due to timeout).This PR changes the assertion when no error is expected to wait for the Teleport ready event and increases the timeout while waiting for events, giving the instance enough time to transition between states.