Generalize resource watchers #47561
Merged
Generalize resource watchers #47561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/generic_resource_watcher
branch
10 times, most recently
from
47236c1 to
50a3ebb
Compare
github-actions
bot
added
application-access
database-access
rosstimothy
force-pushed
the
tross/generic_resource_watcher
branch
from
50a3ebb to
c26f411
Compare
|
Friendly ping @fspmarshall @greedy52 |
greedy52
approved these changes
Oct 24, 2024
I don't really like it either but I don't have many other good ideas. The intent is to try and thwart any modifications to resources during the filter+iteration provided by the resource watcher. Copies of the resources are only made if the filter matches to avoid excessive memory consumption, however, that means callers must be well behaved. |
fspmarshall
approved these changes
Oct 28, 2024
rosstimothy
force-pushed
the
tross/generic_resource_watcher
branch
2 times, most recently
from
7f51dcd to
ca70101
Compare
Consolidate resource watchers into a single watcher that leverages generics. While most of the resource watchers were similar, some resources have some one off functionality. These watchers have not been touched, however, all that could be refactored to use the generic watcher easily were.
rosstimothy
force-pushed
the
tross/generic_resource_watcher
branch
from
ca70101 to
be13733
Compare
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Oct 31, 2024
#47561 incorrectly translated the logic on when to call the diff function for resources. The previous logic only called the differ _if_ the resource was not brand new, however, after the conversion to the generic watcher the differ was always called.
rosstimothy
added a commit
that referenced
this pull request
Oct 31, 2024
#47561 incorrectly translated the logic on when to call the diff function for resources. The previous logic only called the differ _if_ the resource had already been seen before, which guaranteed that both the old and new resource provided to the diff function were not nil. However, after the conversion to the generic watcher the diff function was called for new resources, resulting in a nil value being provided for the old resource and caused a panic. The previous behavior has been restored, and the ProxyWatcher test has been updated to set a diff function to prevent regressions.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47561 incorrectly translated the logic on when to call the diff function for resources. The previous logic only called the differ _if_ the resource had already been seen before, which guaranteed that both the old and new resource provided to the diff function were not nil. However, after the conversion to the generic watcher the diff function was called for new resources, resulting in a nil value being provided for the old resource and caused a panic. The previous behavior has been restored, and the ProxyWatcher test has been updated to set a diff function to prevent regressions.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47561 incorrectly translated the logic on when to call the diff function for resources. The previous logic only called the differ _if_ the resource had already been seen before, which guaranteed that both the old and new resource provided to the diff function were not nil. However, after the conversion to the generic watcher the diff function was called for new resources, resulting in a nil value being provided for the old resource and caused a panic. The previous behavior has been restored, and the ProxyWatcher test has been updated to set a diff function to prevent regressions.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
#47561 incorrectly translated the logic on when to call the diff function for resources. The previous logic only called the differ _if_ the resource had already been seen before, which guaranteed that both the old and new resource provided to the diff function were not nil. However, after the conversion to the generic watcher the diff function was called for new resources, resulting in a nil value being provided for the old resource and caused a panic. The previous behavior has been restored, and the ProxyWatcher test has been updated to set a diff function to prevent regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate resource watchers into a single watcher that leverages generics. While most of the resource watchers were similar, some resources have some one off functionality. These watchers have not been touched, however, all that could be refactored to use the generic watcher easily were.