Replace NewCLIPromptV2
#47927
Merged
Replace NewCLIPromptV2
#47927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Joerger
force-pushed
the
joerger/replace-old-cli-constructor
branch
from
f72be93 to
fb56881
Compare
Joerger
force-pushed
the
joerger/replace-old-cli-constructor
branch
from
fb56881 to
ab970a4
Compare
codingllama
approved these changes
Oct 29, 2024
| @@ -87,6 +72,12 @@ func NewCLIPromptV2(cfg *CLIPromptConfig) *CLIPrompt { | |||
| } | |||
| } | |||
|
|
|||
| // NewCLIPromptV2 returns a new CLI mfa prompt with the given config. | |||
| // TODO(Joerger): remove once /e is no longer dependent on this. | |||
| func NewCLIPromptV2(cfg *CLIPromptConfig) *CLIPrompt { | |||
There was a problem hiding this comment.
When the e/ update lands we can remove this, right?
There was a problem hiding this comment.
Yeah, so 2 more follow up PRs after this 😅
Joerger
force-pushed
the
joerger/replace-old-cli-constructor
branch
from
ab970a4 to
aba6564
Compare
bernardjkim
approved these changes
Oct 30, 2024
Joerger
force-pushed
the
joerger/replace-old-cli-constructor
branch
from
aba6564 to
f282b69
Compare
public-teleport-github-review-bot
bot
removed the request for review
from tcsc
Joerger
added a commit
that referenced
this pull request
Oct 30, 2024
Joerger
added a commit
that referenced
this pull request
Oct 30, 2024
This was referenced Oct 31, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Replace NewCLIPromptV2. (#47927) * Update e ref to branch/v15; Add missing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second follow up to #47874
Depends on https://github.com/gravitational/teleport.e/pull/5251 so that it isn't dependent on
NewCLIPromptV22 more follow ups needed to remove
NewCLIPromptV2from /e and then oss.