-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ha-autoscale-cluster: Source unit file environment variables from /etc/default/teleport #48040
Conversation
…c/default/teleport
This pull request is automatically being deployed by Amplify Hosting (learn more). |
@@ -14,3 +14,8 @@ TELEPORT_ENABLE_POSTGRES=${enable_postgres_listener} | |||
USE_ACM=${use_acm} | |||
USE_TLS_ROUTING=${use_tls_routing} | |||
EOF | |||
cat >>/etc/default/teleport <<EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is /etc/teleport.d/conf also necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that file is sourced all over the place.
I could theoretically rewrite all the places it's used to use /etc/default/teleport
instead, but setting a lot of extra environment variables in the environment file Teleport itself sources might have unintended consequences. It'd also be a huge PR that would need a lot of testing.
At the moment there's a relatively clean split between "environment variables used by Teleport" and "environment variables used by the AMI/unit files".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I added a changelog, don't hesitate to rephrase it.
We'll need to add this in the version fine prints as this can be a breaking change for some users doing weird things.
@webvictim See the table below for backport results.
|
This removes some deprecated code scheduled for cleanup in 17.0.0.
Tested by deploying
ha-autoscale-cluster
with local 16.4.6 OSS and Enterprise AMI builds.Changelog: Teleport AMIs no longer source
/etc/teleport.d/conf
in the Proxy Service systemd unit. Use/etc/default/teleport
if you want to set Proxy Service environment variables.