only preload local cluster cas #48483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
fspmarshall
added
no-changelog
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
bl-nero
reviewed
Nov 6, 2024
ravicious
approved these changes
Nov 6, 2024
fspmarshall
force-pushed
the
fspmarshall/only-preload-local-cas
branch
from
4d7bf1f to
5c96d26
Compare
fspmarshall
force-pushed
the
fspmarshall/only-preload-local-cas
branch
from
5c96d26 to
3eca95b
Compare
|
@fspmarshall See the table below for backport results.
|
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of the client TLS config generator tried to always pre-generate all TLS configs for all known CAs on all changes. This was nice in theory, but created spurious error logs due to remote clusters not having all requisite CAs stored, and was wasted effort in many cases.
This PR tweaks the event-handling logic of the client TLS config generator to only aggressively generate TLS configs in response to modification events for the local cluster. For all other clusters, it invalidates any now stale state, but waits until a connection actually comes in before nothing to try to build the TLS config.
Fixes #48331