-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[teleport-update] Add link subcommand #48712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
force-pushed
the
sclevine/teleport-update-link
branch
from
November 12, 2024 02:06
84bac8f
to
3b37722
Compare
sclevine
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Nov 12, 2024
zmb3
approved these changes
Nov 13, 2024
Could use one more review when someone has a chance 🙂 |
vapopov
approved these changes
Nov 14, 2024
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
November 14, 2024 23:04
public-teleport-github-review-bot
bot
removed request for
hugoShaka and
Joerger
November 14, 2024 23:04
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
link
subcommand to theteleport-update
command.This subcommand will allow the
teleport
RPM and DEB packages to co-exist with versions of Teleport that are installed by theteleport-update
binary, by ensuring that Teleport binaries installed by the package into/usr/local/teleport-system
are always linked to/usr/local
when noteleport-update
-managed installation is present.The
link
subcommand links the system (package) installation of Teleport from/usr/local/teleport-system
to/usr/local/{bin,lib/systemd/system}
. This subcommand will be executed by theteleport
package's postinst script to ensure that when auto-updates are disabled, the package continues to function as it does today. See the RFD linked below for more details.Note that the Teleport package will have its files moved into
/usr/local/teleport-system
in a future PR. This command is not useful until this packaging change is complete.This PR also fixes the following small bugs related to linking:
teleport.service
must be copied instead of linked, sincesystemctl enable
resolves multi-level linksteleport-ent
as the top-level directoryThis is the sixth in a series of PRs implementing
teleport-update
:Update Command: #48244
Reloading with rollbacks: #47929
Linking: #47879
Enable Command: #47565
Initial scaffolding PR: #46418
The
teleport-update
binary will be used to enable, disable, and trigger automatic Teleport agent updates. The new auto-updates system manages a local installation of the cluster-specified version of Teleport stored in/var/lib/teleport/versions
.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/10289
Examples: