Support for joining Actions in un-reachable GitHub Enterprise Servers via Static JWKS #48973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
doggydogworld,
hugoShaka,
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-4gtklpkkt-goteleport.vercel.app/docs/ver/preview |
hugoShaka
approved these changes
Nov 14, 2024
|
🤖 Vercel preview here: https://docs-5yx8ks8v7-goteleport.vercel.app/docs/ver/preview |
tigrato
approved these changes
Nov 15, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
mmcallister,
zmb3 and
xinding33
public-teleport-github-review-bot
bot
removed request for
ptgott and
doggydogworld
|
🤖 Vercel preview here: https://docs-4pq2hkhtp-goteleport.vercel.app/docs/ver/preview |
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Nov 15, 2024
… via Static JWKS (#48973) * Add JWKS based validator for github tokens * Extend proto * Update auth srvr github join impl to support static jwks * Ignore govet * initialize with jwks validator * Update docs * Update terraform shizz * Regenerate various things
ptgott
pushed a commit
that referenced
this pull request
Nov 15, 2024
… via Static JWKS (#48973) * Add JWKS based validator for github tokens * Extend proto * Update auth srvr github join impl to support static jwks * Ignore govet * initialize with jwks validator * Update docs * Update terraform shizz * Regenerate various things
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
…ervers via Static JWKS (#48973) (#49052) * Support for joining Actions in un-reachable GitHub Enterprise Servers via Static JWKS (#48973) * Add JWKS based validator for github tokens * Extend proto * Update auth srvr github join impl to support static jwks * Ignore govet * initialize with jwks validator * Update docs * Update terraform shizz * Regenerate various things * Fix key generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30831
changelog: Added support for directly configuring JWKS for GitHub joining for circumstances where the GHES is not reachable by the Teleport Auth Service.