Add ListDevicesByUser protos #48993
Merged
Add ListDevicesByUser protos #48993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
added
the
no-changelog
zmb3
approved these changes
Nov 14, 2024
codingllama
reviewed
Nov 14, 2024
| @@ -98,6 +98,9 @@ service DeviceTrustService { | |||
| // ListDevices lists all registered devices. | |||
| rpc ListDevices(ListDevicesRequest) returns (ListDevicesResponse); | |||
|
|
|||
| // ListDevicesByUser lists all registered devices for the user. | |||
There was a problem hiding this comment.
Suggested change
| // ListDevicesByUser lists all registered devices for the user. | |
| // ListDevicesByUser lists all devices owned by the user |
Registered here largely relates to inventory management, so it's best to avoid the word. Technically we could say "devices enrolled by the user" but I think the suggestion is good enough.
There was a problem hiding this comment.
that makes total sense. I'll keep that in mind with future comments for the service too
| // | ||
| // Follows the pagination semantics of | ||
| // https://cloud.google.com/apis/design/standard_methods#list. | ||
| message ListDevicesByUserRequest { |
There was a problem hiding this comment.
nit: Move above ListDevicesByUserResponse, so the RPC pair is close together?
These support the upcoming service to allow users to see a list of their own registered devices in the web UI account settings page.
avatus
force-pushed
the
avatus/devices
branch
from
79495c4 to
57c50c8
Compare
codingllama
approved these changes
Nov 14, 2024
public-teleport-github-review-bot
bot
removed request for
flyinghermit and
kimlisa
avatus
added a commit
that referenced
this pull request
Nov 21, 2024
These support the upcoming service to allow users to see a list of their own registered devices in the web UI account settings page.
This was referenced Nov 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Add ListDevicesByUser protos (#48993) These support the upcoming service to allow users to see a list of their own registered devices in the web UI account settings page. * Remove DeviceView from ListDevicesByUser (#49209) Originally, we included the `View` field in order to add the Owner property to safeguard the returned details of a device ensure the owner matched the caller. However, this ended up not being conditionally used (we would never _not_ use it) so we can remove it from the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These support the upcoming service to allow users to see a list of their own registered devices in the web UI account settings page.