Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postrelease: automatically update the Go version #49116

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Nov 16, 2024

Extract the Go version from go.mod and use it when we update the version numbers used throughout the docs.

This has several advantages:

  1. We no longer need to remember to periodically update this variable. For example, Teleport 17 was built with Go 1.23 but the docs still (incorrectly) mention Go 1.22.
  2. We get even more precision, as we'll start using the full patch version of Go instead of only the minor.

Extract the Go version from go.mod and use it when we update the
version numbers used throughout the docs.

This has several advantages:
1. We no longer need to remember to periodically update this variable.
   For example, Teleport 17 was built with Go 1.23 but the docs still
   (incorrectly) mention Go 1.22.
2. We get even more precision, as we'll start using the full patch
   version of Go instead of only the minor.
@github-actions github-actions bot requested a review from avatus November 16, 2024 16:36
@github-actions github-actions bot requested a review from vapopov November 16, 2024 16:36
@zmb3 zmb3 added the no-changelog Indicates that a PR does not require a changelog entry label Nov 16, 2024
@zmb3 zmb3 marked this pull request as draft November 16, 2024 17:14
@zmb3 zmb3 marked this pull request as ready for review November 16, 2024 17:42
@github-actions github-actions bot requested review from mvbrock and tigrato November 16, 2024 17:42
@zmb3 zmb3 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into master with commit 79a1680 Nov 18, 2024
44 of 45 checks passed
@zmb3 zmb3 deleted the zmb3/postrelease-go-version branch November 18, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants