Fix unmarshalling of CreateDatabaseUserMode #49995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl-nero
added
no-changelog
marcoandredinis
approved these changes
Dec 10, 2024
codingllama
reviewed
Dec 11, 2024
| @@ -2253,8 +2253,23 @@ func (h CreateDatabaseUserMode) encode() (string, error) { | |||
| func (h *CreateDatabaseUserMode) decode(val any) error { | |||
| var str string | |||
| switch val := val.(type) { | |||
| case int32: | |||
| return trace.Wrap(h.setFromEnum(val)) | |||
| case int64: | |||
There was a problem hiding this comment.
Why do we need to handle so many distinct types? Do we really expect inputs to vary this much?
There was a problem hiding this comment.
@codingllama Frankly, I don't know; I think that only floats would do, but I noticed that the other type (CreateHostUserMode) has it defined this way, so I decided to follow it to maintain consistency.
There was a problem hiding this comment.
I think if you decode from json it'll always be a float64, so I found the other types curious. Technically it doesn't hurt so I won't block you for this.
|
@codingllama I also changed the other test cases around for consistency. |
bl-nero
requested review from
codingllama
and removed request for
fspmarshall
codingllama
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to support this field in the new role editor, since data returned from
/webapi/yaml/stringifycontains numeric enum values. When fed intoPUT /webapi/roles:name, it then resulted in an error.