Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Filter while paging in GetByVMID #49998

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

rosstimothy
Copy link
Contributor

Backport #49968 to branch/v17

changelog: Reduce Auth memory consumption when agents join using the azure join method.

This updates GetByVMID, used by azure joining, to filter by id for
each page of vms instead of filtering after accumulating _all_ vms
in memory first. While this does reduce memory consumption, the listing
process is still suboptimal in that _all_ instances in a subscription
are retrieved in response to _every_ join request.
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49998.d212ksyjt6y4yg.amplifyapp.com

@rosstimothy rosstimothy marked this pull request as ready for review December 10, 2024 14:50
@github-actions github-actions bot requested review from hugoShaka and zmb3 December 10, 2024 14:51
@hugoShaka
Copy link
Contributor

Are we sure we want to backport this PR? As Teleport is currently experiencing rate-limiting on some large Azure environments, I fear that this PR might increase the call rate and make things worse.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from hugoShaka December 10, 2024 17:01
@rosstimothy rosstimothy added this pull request to the merge queue Dec 11, 2024
Merged via the queue into branch/v17 with commit 9db0829 Dec 11, 2024
45 checks passed
@rosstimothy rosstimothy deleted the bot/backport-49968-branch/v17 branch December 11, 2024 18:39
@fheinecke fheinecke mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants