[v17] Support configuring DNS SANs for X509 SVIDs using WorkloadIdentity resource (#50676) #50761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source (#50676) * Extend the protobuf * Wire up DNS SAN field to issuance code * Regenerate tfschema * Add DNS SANs to the audit event * Add test * Rename to x509 * Add test/check that validates hostname generated * Fix TS proto * Update lib/auth/machineid/workloadidentityv1/decision_test.go Co-authored-by: Tim Buckley <tim@goteleport.com> --------- Co-authored-by: Tim Buckley <tim@goteleport.com>
strideynet
added
the
no-changelog
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
github-actions
bot
requested review from
marcoandredinis,
tigrato and
timothyb89
marcoandredinis
approved these changes
Jan 6, 2025
tigrato
approved these changes
Jan 6, 2025
public-teleport-github-review-bot
bot
removed the request for review
from timothyb89
|
Amplify deployment status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #50676