Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify awsconfig loading #50809

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

GavinFrazar
Copy link
Contributor

@GavinFrazar GavinFrazar commented Jan 7, 2025

This replaces awsconfig.WithIntegrationCredentialProvider option with the awsconfig.WithOIDCIntegrationClient option.
This solves a chicken/egg problem with AWS config loading - callers no longer need to load AWS config (to create an AWS OIDC integration credential provider) to load AWS config.
The OIDCIntegrationClient interface is also much simpler to implement.

This also adds default option overrides when creating an awsconfig.Cache. For now, this is used to add an OIDCIntegrationClient when creating the cache so that dependent callers don't have to.

@GavinFrazar GavinFrazar added the no-changelog Indicates that a PR does not require a changelog entry label Jan 7, 2025
@GavinFrazar GavinFrazar added the aws Used for AWS Related Issues. label Jan 7, 2025
This replaces awsconfig.WithIntegrationCredentialProvider option with the
awsconfig.WithOIDCIntegrationClient option.
This solves a chicken/egg problem with AWS config loading - callers no
longer need to load AWS config (to create a credential provider) to load
AWS config.
The OIDCIntegrationClient interface is also much simpler to implement.

This also adds default option overrides when creating an awsconfig.Cache.
For now, this is used to add an OIDCIntegrationClient when creating the
cache so that dependent callers don't have to.
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/simplify-aws-config-loading branch from 321ecff to 7ad1ad3 Compare January 7, 2025 03:36
@GavinFrazar GavinFrazar marked this pull request as ready for review January 7, 2025 03:36
@github-actions github-actions bot requested a review from EdwardDowling January 7, 2025 03:37
@GavinFrazar GavinFrazar added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 20828a2 Jan 8, 2025
45 of 46 checks passed
@GavinFrazar GavinFrazar deleted the gavinfrazar/simplify-aws-config-loading branch January 8, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Used for AWS Related Issues. discovery no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants