Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] chore: Bump golangci-lint to v1.63.4 #50868

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

codingllama
Copy link
Contributor

Backport #50846 to branch/v15.

* chore: Bump golangci-lint to v1.63.4

* Change output.uniq-by-line to issues.uniq-by-line
@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Jan 8, 2025
@codingllama codingllama requested a review from tigrato January 8, 2025 14:20
@codingllama codingllama enabled auto-merge January 8, 2025 14:20
@codingllama
Copy link
Contributor Author

Some interesting failures over here, 👀.

@codingllama
Copy link
Contributor Author

codingllama commented Jan 8, 2025

I've added ignores for the govet/stdversion warnings because we are using 1.22 as the toolchain, so it all actually builds (and tests) correctly. (Technically the linter is correct but changing all that code seems worse to me.)

Loopvar issues I've just fixed.

Ideally this would pull https://github.com/gravitational/teleport.e/pull/5813 as well, but it isn't a hard-requirement.

Edit: updated e/.

@creack
Copy link
Member

creack commented Jan 8, 2025

nit: wouldn't it be better/easier to bump v15 go version?

@codingllama
Copy link
Contributor Author

nit: wouldn't it be better/easier to bump v15 go version?

It's an option. I would do it separately (and then remove the ignores). WDYT @rosstimothy?

@creack
Copy link
Member

creack commented Jan 8, 2025

imho we should keep all the backport version up to date, not just to avoid this kind of issue, but to benefit from any bug/security fixes.

@codingllama
Copy link
Contributor Author

imho we should keep all the backport version up to date, not just to avoid this kind of issue, but to benefit from any bug/security fixes.

Toolchains are up to date, this is only about the module Go level.

@codingllama codingllama added this pull request to the merge queue Jan 8, 2025
Merged via the queue into branch/v15 with commit a174bd4 Jan 8, 2025
34 of 35 checks passed
@codingllama codingllama deleted the codingllama/backport/50846-v15 branch January 8, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants