-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v15] chore: Bump golangci-lint to v1.63.4 #50868
Conversation
* chore: Bump golangci-lint to v1.63.4 * Change output.uniq-by-line to issues.uniq-by-line
Some interesting failures over here, 👀. |
I've added ignores for the govet/stdversion warnings because we are using 1.22 as the toolchain, so it all actually builds (and tests) correctly. (Technically the linter is correct but changing all that code seems worse to me.) Loopvar issues I've just fixed. Ideally this would pull https://github.com/gravitational/teleport.e/pull/5813 as well, but it isn't a hard-requirement. Edit: updated e/. |
nit: wouldn't it be better/easier to bump v15 go version? |
It's an option. I would do it separately (and then remove the ignores). WDYT @rosstimothy? |
imho we should keep all the backport version up to date, not just to avoid this kind of issue, but to benefit from any bug/security fixes. |
Toolchains are up to date, this is only about the module Go level. |
Backport #50846 to branch/v15.