Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15] Permit routing to agentless nodes with non-UUID metadata.name #50926

Open
wants to merge 1 commit into
base: branch/v15
Choose a base branch
from
Open

[v15] Permit routing to agentless nodes with non-UUID metadata.name #50926

wants to merge 1 commit into from
+59 −11

Conversation

rosstimothy
Copy link
Contributor

Backport #50915 to branch/v15

changelog: Prevent routing issues for agentless nodes that are created with non-UUID metadata.name fields.

@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
fec49fe 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardjkim bernardjkim bernardjkim approved these changes

@fspmarshall fspmarshall Awaiting requested review from fspmarshall

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosstimothy @bernardjkim