Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Convert github auth code to use x/oauth2 #51084

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 commented Jan 15, 2025

backport of #48598 to branch/v17

no conflict. backporting as it's dependency for github proxy backport.

Replaces the dependency on go-oidc/oauth2 with x/oauth2 in the
github connector auth flows. One result of the switch is that it
permitted a lot of simplification - the github client cache used
by the auth server was removed entirely.
@greedy52 greedy52 added backport no-changelog Indicates that a PR does not require a changelog entry labels Jan 15, 2025
@greedy52 greedy52 requested a review from rosstimothy January 15, 2025 20:43
@greedy52 greedy52 mentioned this pull request Jan 15, 2025
4 tasks
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from rosstimothy January 16, 2025 10:42
@greedy52 greedy52 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into branch/v17 with commit 3b41427 Jan 16, 2025
42 of 43 checks passed
@greedy52 greedy52 deleted the STeve/backport/v17/48598 branch January 16, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants