-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP Server AutoDiscover: only log when the script fails #51117
GCP Server AutoDiscover: only log when the script fails #51117
Conversation
a060d61
to
decc9ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is logged in the loop over different IP addresses, so we may end up in a situation where subsequent attempt to a different IP address succeeds, but we logged an error-level information anyway. I think we should only log an error once we are sure we have ran out of IP addresses to try. So perhaps some kind of aggregate error?
When running Auto Discover for GCP VMs, teleport always logs the output in debug level. Now, it only logs the stdout/stderr when the installation fails. It also adds some context on which VMs it failed and the log level is now Error.
decc9ee
to
01fc2f4
Compare
I've change things slightly. |
@marcoandredinis See the table below for backport results.
|
* GCP Server AutoDiscover: only log when the script fails When running Auto Discover for GCP VMs, teleport always logs the output in debug level. Now, it only logs the stdout/stderr when the installation fails. It also adds some context on which VMs it failed and the log level is now Error. * Log once per RunCommand invocation
When running Auto Discover for GCP VMs, teleport always logs the output in debug level.
Now, it only logs the stdout/stderr when the installation fails. It also adds some context on which VMs it failed and the log level is now Error.
Related: #45172