Stable UNIX users: functionality #51200
Open
+2,254
−1,170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
added
the
no-changelog
github-actions
bot
added
audit-log
rosstimothy
reviewed
Jan 24, 2025
| @@ -233,8 +248,21 @@ func (s *server) obtainUIDForUsernameUncached(ctx context.Context, username stri | |||
| return 0, trace.Wrap(err) | |||
| } | |||
|
|
|||
| // TODO(espadolini): emit an audit log event with the username and UID | |||
| // that was just created | |||
| if s.emitter != nil { | |||
There was a problem hiding this comment.
Should the emitter be required to be non-nil in the New?
Comment on lines
+329
to
+332
| log.DebugContext(ctx, "Host user does not exist and no UID is configured, obtaining fallback UID") | ||
| fallbackUID, ok, err := obtainFallbackUID(ctx, identityContext.Login) | ||
| if err != nil { | ||
| log.ErrorContext(ctx, "Failed to obtain fallback (stable) UID from control plane", "error", err) |
There was a problem hiding this comment.
Should we refer to these as fallback, stable or configured uid? Are they really a fallback or are they primary UID if I've enabled stable_unix_user_config in my auth preference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of fallback UIDs for host user creation in the Teleport SSHd and a
tctlsubcommand (tctl stable-unix-users ls) to list the persisted usernames and their UIDs. This PR also adds an audit log event to the API, emitted when a new username is written.Related RFD: #50414
Part of #50292