APIM 7550 fix get archived applications info #10072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukul-tyagi08
force-pushed
the
APIM-7550-fix-get-archived-applications-info
branch
3 times, most recently
from
33f066a to
dc780a4
Compare
mukul-tyagi08
force-pushed
the
APIM-7550-fix-get-archived-applications-info
branch
from
dc780a4 to
950debb
Compare
Okhelifi
reviewed
Dec 13, 2024
| @@ -233,17 +233,28 @@ public ApplicationEntity findById(final ExecutionContext executionContext, Strin | |||
| } | |||
|
|
|||
| @Override | |||
| public Set<ApplicationListItem> findByIds(final ExecutionContext executionContext, Collection<String> applicationIds) { | |||
| public Set<ApplicationListItem> findByIds(ExecutionContext executionContext, Collection<String> applicationIds) { | |||
There was a problem hiding this comment.
Previously, the findByIds method implicitly searched applications by id and ApplicationStatus.ACTIVE by default. By replacing it with your implementation, you've altered the behaviour for all existing resources or services that currently rely on this method.
Could you please verify whether this method is still being called elsewhere? If so, ensure that the default behaviour hasn't been unintentionally modified. If the change impacts existing functionality, consider using your findByIdsAndStatus method explicitly to preserve the intended behaviour.
There was a problem hiding this comment.
- I replaced/renamed findByIds to findByIdsAndStatus and updated all the usages/calls by adding additional parameter: ApplicationStatus.Active
- Then I added a new method findByIds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-7550
Description
Additional context