Apim 8042 native api publish auth and non auth plans #10212
+412
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nflicting auth types
jourdiw
force-pushed
the
apim-8042-native-api-publish-auth-and-non-auth-plans
branch
from
f82e18e to
69a6170
Compare
ThibaudAV
reviewed
Dec 23, 2024
|
|
||
| private nativeKafkaDialog$(plan: Plan, plansToClose: Plan[]): Observable<Plan> { | ||
| const plansWithAuthentication = `plan${plansToClose.length > 1 ? 's' : ''} with authentication`; | ||
| const content = `Kafka APIs cannot have both plans with and without authentication published. Are you sure you want to publish the plan ${plan.name}? <br /><br />Your published ${plan.security.type === 'KEY_LESS' ? plansWithAuthentication : 'Keyless plan'} will be closed automatically.`; |
There was a problem hiding this comment.
I think we need to check the behaviour with subscription. And indicate here that closing a plan with security will close the associated subscriptions. Like the message that closes a plan with security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-8042
Description
Screen.Recording.2024-12-20.at.18.39.22.mov
Next Steps:
Additional context
📚 View the storybook of this branch here