Skip to content

feat: add while list for secrets.get() methods #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat: add while list for secrets.get() methods #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/resources/whitelist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ method io.gravitee.gateway.api.http.HttpHeaders toSingleValueMap

method io.gravitee.common.util.MultiValueMap containsAllKeys java.util.Collection

method io.gravitee.secrets.api.el.DelegatingEvaluatedSecretsMethods get java.lang.String
method io.gravitee.secrets.api.el.DelegatingEvaluatedSecretsMethods get java.lang.String java.lang.String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a small test case but approved anyway 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add it in the service-secrets where I test all EL expressions, unless you had something else in mind

method io.gravitee.secrets.api.el.DelegatingEvaluatedSecretsMethods fromGrant java.lang.String io.gravitee.secrets.api.el.SecretFieldAccessControl
method io.gravitee.secrets.api.el.DelegatingEvaluatedSecretsMethods fromGrant java.lang.String java.lang.String io.gravitee.secrets.api.el.SecretFieldAccessControl
method io.gravitee.secrets.api.el.DelegatingEvaluatedSecretsMethods fromEL java.lang.String java.lang.String io.gravitee.secrets.api.el.SecretFieldAccessControl
Expand Down