Strip userinfo from git-open remote URLs #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Strip userinfo from git-open remote URLs
Summary
Normalize remotes by stripping userinfo across ssh/http(s) and scp-style URLs and add tests to cover non-git users and credentialed HTTPS remotes.
Problem
git-normalize-remote-urlshould produce browser-safe https URLs without embedded credentials regardless of remote username.alice@github.com:org/repo.git) stay unnormalized and https remotes with userinfo keep credentials in the URL.git-opencan emit invalid URLs or leak credentials in terminal output.Reproduction
git remote set-url origin alice@github.com:org/repo.git.git-normalize-remote-url origin.https://github.com/org/repoalice@github.com:org/repoIssues Found
Severity: medium
Confidence: high
Status: open | fixed | deferred | needs-info
Fix Approach
Testing
zsh -f tests/git-open-normalize-remote-url.test.zsh(pass)Risk / Notes