Address PR comments

Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0 · Nov 14, 2024 · 963351c · 963351c
1 parent 491d50a
commit 963351c
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/.../main/java/org/opensearch/dataprepper/plugins/codec/parquet/GenericRecordJsonEncoder.java b/.../main/java/org/opensearch/dataprepper/plugins/codec/parquet/GenericRecordJsonEncoder.java
@@ -11,6 +11,7 @@
 import java.util.HashMap;
 import java.util.IdentityHashMap;
 import java.util.Map;
+import java.util.Optional;
 import java.util.function.Function;
 
 import org.apache.avro.LogicalType;
@@ -120,8 +121,9 @@ private void serialize(final Object datum, final StringBuilder buffer, final Ide
             buffer.append("\"");
         } else if (isBytes(datum)) {
             final String bytesAsString = StandardCharsets.UTF_8.decode((ByteBuffer) datum).toString();
-            if (isBigDecimal(bytesAsString)) {
-                buffer.append(new BigDecimal(bytesAsString).doubleValue());
+            final Optional<BigDecimal> bytesAsBigDecimal = getBigDecimal(bytesAsString);
+            if (bytesAsBigDecimal.isPresent()) {
+                buffer.append(bytesAsBigDecimal.get().doubleValue());
             } else {
                 buffer.append("{\"bytes\": \"");
                 ByteBuffer bytes = ((ByteBuffer) datum).duplicate();
@@ -192,12 +194,11 @@ private void writeEscapedString(String string, StringBuilder builder) {
         builder.append(StringEscapeUtils.escapeJava(string));
     }
 
-    private boolean isBigDecimal(String decimalString) {
+    private Optional<BigDecimal> getBigDecimal(String decimalString) {
         try {
-            final BigDecimal bigDecimal = new BigDecimal(decimalString);
-            return true;
+            return Optional.of(new BigDecimal(decimalString));
         } catch (final Exception e) {
-            return false;
+            return Optional.empty();
         }
     }
 }