[BUGFIX] Raise error when ExpectColumnValuesToBeBetween is run against an unsupported column #10995
+103
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10995 +/- ##
========================================
Coverage 80.88% 80.88%
========================================
Files 484 484
Lines 40900 40911 +11
========================================
+ Hits 33081 33092 +11
Misses 7819 7819
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshua-stauffer
deleted the
m/gx-306/check_python_types_before_generating_min_max_sql
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enforce that max_value and min_value for ExpectColumnValuesToBeBetween must be a numeric or datetime type, but we don't check the underlying data. In SQL contexts where the underlying data is something else such as VARCHAR, users receive opaque exceptions generated by their database, and it isn't clear what they should do to resolve the error. Worse, because of how we bundle metric computations into a single SQL query, every expectation computed in the same run will likely fail with the same opaque error.
This PR updates the ColumnValuesBetween metric to make a basic check against the column type prior to building the query.