[CONTRIB] Fix row_condition handling for SQLAlchemyExecutionEngine#11742
[CONTRIB] Fix row_condition handling for SQLAlchemyExecutionEngine#11742Mallik544 wants to merge 3 commits intogreat-expectations:developfrom
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 8b61fc1 |
|
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: mallikramassani@gmail.com |
for more information, see https://pre-commit.ci
|
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: mallikramassani@gmail.com |
|
Hi maintainers, It looks like CI is failing at the I’ve validated the change locally: Could someone please re-run or approve the workflow so the full CI can execute? Thanks! |
|
@cla-bot check |
|
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: mallikramassani@gmail.com |
joshua-stauffer
changed the title
|
@cla-bot check |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11742 +/- ##
===========================================
- Coverage 84.59% 84.46% -0.13%
===========================================
Files 473 473
Lines 39260 39262 +2
===========================================
- Hits 33211 33162 -49
- Misses 6049 6100 +51 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshua-stauffer
left a comment
joshua-stauffer
left a comment
There was a problem hiding this comment.
thanks for the PR, @Mallik544 . Looks like we need a test case - the original issue mentions postgres, so that's probably the most straightforward candidate. I'd suggest using the parameterize_batch_for_data_sources fixture with PostgreSQLDatasourceTestConfig in the tests/integration/data_sources_and_expectations package.
|
Note that the original issue used the legacy |
3 participants
Summary
Fixes row_condition handling in SqlAlchemyExecutionEngine by wrapping non-table selectables in a subquery before applying the filter.
Problem
When applying row_condition, the code used select_from(selectable) directly. For non-table selectables, this could generate malformed SQL or fail under SQLAlchemy 2.0-style handling.
Changes
Testing
python -m pytest tests\expectations\test_row_conditions.py -x -k "not spark"
Related Issue
Closes #11319