Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] FILES_TO_COMMIT correctly uses list comprehnesion to stage files #43

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[BUGFIX] FILES_TO_COMMIT correctly uses list comprehnesion to stage files #43

merged 1 commit into from
Jul 26, 2023

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Jul 21, 2023 •
edited
Loading

Was running into the following error when using ge_releaser prep command. Bugfix to use list-comprehension

(supercon_ge) ➜  great_expectations git:(develop) ge_releaser prep                        

[prep]
 * Created a release branch (1/7)
 * Updated deployment version file (2/7)
 * Updated version in docs data component (3/7)
 * Updated version in docs version dropdown (4/7)
 * Updated changelogs (5/7)
  cmdline: git add GxFile.CHANGELOG_MD GxFile.DOCS_DATA_COMPONENT GxFile.DOCS_CONFIG GxFile.CHANGELOG_RST GxFile.DEPLOYMENT_VERSION
  stderr: 'fatal: pathspec 'GxFile.CHANGELOG_MD' did not match any files'

@Shinnnyshinshin Shinnnyshinshin changed the title [BUGFIX] FILES_TO_COMMIT correctly uses list comprehnsion to stage files [BUGFIX] FILES_TO_COMMIT correctly uses list comprehnesion to stage files Jul 21, 2023
@Shinnnyshinshin Shinnnyshinshin self-assigned this Jul 21, 2023
@Shinnnyshinshin Shinnnyshinshin merged commit 4b17754 into main Jul 26, 2023
@Shinnnyshinshin Shinnnyshinshin deleted the b/_/bugfix-for-files-to-commit-enum branch July 26, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdkini cdkini cdkini approved these changes

Assignees

@Shinnnyshinshin Shinnnyshinshin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shinnnyshinshin @cdkini