Update to Amaranth 0.5

[miek]

Work-in-progress on updating to Amaranth 0.5:

• Replace uses of amaranth.hdl.Memory with amaranth.lib.memory.Memory
• Remove uses of Signal.width
• Replace uses of reset= with init=
• Remove uses of Pin
• Update tests to remove uses of add_sync_process
• ...

[miek]

I think this is ready for review now.

I decided to drop the synchronize helper in favour of less magic and because it was tied pretty closely to Pin/Record which are going away. Most of its uses were from unmaintained examples that depended on old hardware, that I've also removed.

I also decided to skip porting away from add_sync_process for now as refactoring all the tests is going to be a big job, and I'd rather leave that to a follow-up PR, so the test runs will have a deprecation warning relating to that.

Otherwise it's all fairly simple changes from the list here: https://amaranth-lang.org/docs/amaranth/latest/changes.html#migrating-from-version-0-4

[zyp]

It's not necessary to explicitly construct a Shape here, any shape-like can be used, and since that includes integers, you can simply just pass shape=self.sample_width. shape is effectively a superset of the old width argument.

This goes for the other Memory instances in this commit as well.

[miek]

Fixed, thanks!

[antoinevg]

We're also going to need a smol change to luna/gateware/usb/request/windows/ms_descriptor.py:

diff --git a/luna/gateware/usb/request/windows/ms_descriptor.py b/luna/gateware/usb/request/windows/ms_descriptor.py
index b89f188..a6b5493 100644
--- a/luna/gateware/usb/request/windows/ms_descriptor.py
+++ b/luna/gateware/usb/request/windows/ms_descriptor.py
@@ -184,7 +184,7 @@ class GetMicrosoftDescriptorHandlerBlock(Elaboratable):
         rom_content, descriptor_max_length, max_index, min_index = self.generate_rom_content()

         m.submodules.rom = rom = Memory(shape=32, depth=len(rom_content), init=rom_content)
-        rom_read_port = rom.read_port(transparent=False)
+        rom_read_port = rom.read_port()

         # Create convenience aliases to the upper and lower half of the ROM.
         rom_upper_half = rom_read_port.data.word_select(1, 16)

Amaranth 0.5 read ports are now not transparent by default, with transparency being set with the transparent_for parameter containing zero or more WritePorts:

read_port(*, domain='sync', transparent_for=(), src_loc_at=0)

[miek]

Good catch, thanks! I've fixed that and also updated a use of Memory I'd missed in the superspeed code.

[antoinevg]

Looking great, ready to merge!