Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented InfiniteScrollListView and Fixed Tests #23

Merged

Conversation

matsuyani556
Copy link
Collaborator

Issue Number

fixes #21
fixes #22

Summary

  • Feat: Implemented InfiniteScrollListView

    • A new widget, InfiniteScrollListView, has been implemented to add infinite scroll functionality to Flutter’s ListView and GridView.
      This widget dynamically fetches data as the user scrolls and supports both forward and backward scrolling. Additionally, it includes an initialIndex parameter to specify the initial display position in the list or grid, allowing data to be displayed starting from a specific position.
  • Fix: Fixed flutter test Failure on Windows

    • Resolved an issue where flutter test was failing on Windows due to errors caused by path separator differences.

@matsuyani556 matsuyani556 changed the title Feature/infinite scroll list view Implemented InfiniteScrollListView and Fixed Tests Nov 6, 2024
@matsuyani556
Copy link
Collaborator Author

The following error is occurring in GitHub Actions:

$ melos exec
  └> dart analyze . --fatal-infos
     └> FAILED (in 1 packages)
        └> patapata_riverpod (with exit code 1)

This issue can be resolved by merging #20.

/// A widget that provides infinite scrolling functionality to ListView or GridView.
///
/// This widget fetches data of type T using the fetch method when the user scrolls
/// the list or grid and calls the itemBuilder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// the list or grid and calls the itemBuilder.
/// the list or grid and calls the [itemBuilder].

import 'package:patapata_core/patapata_core.dart';
import 'package:provider/provider.dart';

/// A widget that provides infinite scrolling functionality to ListView or GridView.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// A widget that provides infinite scrolling functionality to ListView or GridView.
/// A widget that provides infinite scrolling functionality to [ListView] or [GridView].


/// A widget that provides infinite scrolling functionality to ListView or GridView.
///
/// This widget fetches data of type T using the fetch method when the user scrolls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// This widget fetches data of type T using the fetch method when the user scrolls
/// This widget fetches data of type [T] using either of the [fetchNext] or [fetchPrevious] methods when the user scrolls

@matsuyani556 matsuyani556 force-pushed the feature/infinite-scroll-list-view branch from 21e4cc4 to c89d645 Compare November 14, 2024 09:03
@matsuyani556 matsuyani556 merged commit 8ddd786 into gree:main Nov 14, 2024
2 checks passed
@matsuyani556 matsuyani556 deleted the feature/infinite-scroll-list-view branch November 14, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants