Display initial selected values when component is initialized#24
Open
eliotpiering wants to merge 2 commits intogreen-arrow:masterfrom
Open
Display initial selected values when component is initialized#24eliotpiering wants to merge 2 commits intogreen-arrow:masterfrom
eliotpiering wants to merge 2 commits intogreen-arrow:masterfrom
Conversation
…o that ember-chosen will show initial values
Owner
|
Thanks for this @eliotpiering Tests are something this project really needs. I started this addon at an old job, then moved jobs and things got really hectic, hence this addon not really getting the attention it deserves. If you want, I would gladly welcome tests around this 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just triggers the 'chosen:updated' event with the initial 'currentValue' when the component is initialized so that chosen will create li elements for anything that was already in value. This solutions seems to work well in the multiple select case and should work with a single select, but I have not tested thoroughly. I'm happy to write some tests around this but I didn't really see any others in the repo.