Skip to content

[EC66] deprecation of EC66 rule for Python #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dedece35 merged 2 commits into from
Dec 15, 2023
Merged

[EC66] deprecation of EC66 rule for Python #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
170e25f
[ISSUE 4] deprecation of EC66 rule for Python
dedece35 Dec 11, 2023
16cae3e
Merge branch 'main' into ISSUE_4
dedece35 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Deleted

- [#4](https://github.com/green-code-initiative/ecoCode-python/issues/4) Deprecate rule EC66 for Python because not applicable (see details inside issue)

## [1.4.0] - 2023-08-08

### Added
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/fr/greencodeinitiative/python/checks/AvoidDoubleQuoteCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
import org.sonar.plugins.python.api.tree.StringLiteral;
import org.sonar.plugins.python.api.tree.Tree;

/**
* @deprecated not applicable for Python
* (check discussion inside issue https://github.com/green-code-initiative/ecoCode-python/issues/4)
*/
@Deprecated(forRemoval = true)
@Rule(key = "EC66")
public class AvoidDoubleQuoteCheck extends PythonSubscriptionCheck {
public static final String MESSAGE_RULE = "Avoid using quotation mark (\"), prefer using simple quote (')";
Expand Down
1 change: 1 addition & 0 deletions src/test/java/fr/greencodeinitiative/python/checks/AvoidDoubleQuoteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import org.junit.Test;
import org.sonar.python.checks.utils.PythonCheckVerifier;

@Deprecated
public class AvoidDoubleQuoteTest {
@Test
public void test() {
Expand Down