fix: fix memory leak on failed http requests #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many error cases the http response body was not closed as the `defer` statement was only executed after the error handling. Thus the connection can't be reused. This caused the creation of many goroutines, massively increasing the memory consumption. A prominent scenario is if a CSAF provider does not provide both sha256 and sha512 checksums.
Conventional Commits Report
🚀 Conventional commits found. |
llugin
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix memory leak on failed http requests.
In many error cases the http response body was not closed as the
deferstatement closing the body was only executed after the error handling.Thus the underlying connection can't be reused. This caused the creation of many goroutines which are never discarded, massively increasing the memory consumption.
A prominent scenario is if a CSAF provider does not provide both sha256 and sha512 checksums.
Why
Ever growing memory consumption is an issue.
References
Jira Ticket: VTI-405