-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: move gvm_json_string_escape to a new file #852
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
949f05a
to
53a0527
Compare
🔍 Vulnerabilities of
|
digest | sha256:3963db93fc6803b2130084e82fcc6f594f63ebed1964d07b2a7a95625d6f9c57 |
vulnerabilities | |
size | 69 MB |
packages | 204 |
📦 Base Image debian:testing-20250113-slim
also known as |
|
digest | sha256:ba4db7666a71884a240c1a760e7702fae1eda1ce7ab7c801f1a7cb2769f1e0eb |
vulnerabilities |
Description
Description
Description
Description
| ||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||
Description
Description
Description
Description
| ||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||
Description
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
What
Move the utility function
gvm_json_string_escape
to a new file.Why
This is the start of collecting generic JSON utilities in a dedicated file.
Everything else in
jsonpull.c
is specific to the JSON pull facility. This also helps reduce the size ofjsonpull.c
.The idea is to put more generic functions into
json.c
in the future. For exampleopenvasd.c
andvtparser.c
are using a lot of repeated cJSON code snippets to access doubles. These snippets could be replaced by agvm_json_obj_double
function injson.c
.This also will help to centralize the use of cJSON.
Checklist
I've tested running an
ospd
scan with the new scanner. Seems fine.