-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: unit-tests in openvas-scanner #1732
base: main
Are you sure you want to change the base?
Conversation
…#1730) * Change: Update gvm-libs image in prod.Dockerfile and build.Dockerfile * Update prod.Dockerfile --------- Co-authored-by: Robert Schardt <robert.schardt@Macbook-Robert-Schardt.local>
This comment was marked as resolved.
This comment was marked as resolved.
6b19ce5
to
a41f006
Compare
Dependency ReviewThe following issues were found:
|
To fix openssl error in functional.yml: https://github.com/greenbone/openvas-scanner/actions/runs/11177195503/job/31072763918
Installed pkg-config with libssl-dev as mentioned in crate documentation for openssl-sys: https://docs.rs/openssl/0.10.66/openssl/ However it still fails.. Update: |
7ab0a3a
to
e3a597f
Compare
Regarding the testing and oldstable bulds we need a versions of gvm-libs for that. Those seem to be currently missing. |
@@ -24,7 +24,7 @@ RUN ./configure | |||
RUN make install | |||
RUN ldconfig | |||
|
|||
RUN curl -o /tmp/openssl.tar.gz https://www.openssl.org/source/old/1.1.1/openssl-1.1.1.tar.gz | |||
RUN curl -L -o /tmp/openssl.tar.gz https://www.openssl.org/source/old/1.1.1/openssl-1.1.1.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't curl -Lfo be better to indicate early that it failed to load instead of later when tar tries to extract a html page?
What:
Fix: unit-tests in openvas-scanner
Ticket: https://jira.greenbone.net/browse/DEVOPS-1251
Fail: https://github.com/greenbone/openvas-scanner/actions/runs/11065187998/job/30744175259
Why:
We want to fix the Unit Tests in CI, so the product gets properly built.
How:
Look at CI Unit-Test and see if they fail.
Checklist: