-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use semver instead of calver for python-gvm releases #1197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
Conventional Commits Report
🚀 Conventional commits found. |
f6a46a0
to
b81e4ff
Compare
We decided to use semantic instead if calendar versioning with the next release. This will allow to declare API compatibility constrains with every release.
Extend the version chapter in the README to explain our release choices.
Use all upper case naming for GMP. Some time in the past we agreed on using all upper case naming for abbreviations.
Don't mix indentation and tripple quotes for code blocks in the README and use a single style only.
We have 2025 now.
Run the linter with Python >= 3.9 as the target. This wasn't an issue yet but might have caused problems with running ruff with older Python version ins future. Until the end of the year we still support Python 3.9.
b81e4ff
to
9048f23
Compare
y0urself
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update release workflow to use semver instead of calver for python-gvm releases
Why
We decided to use semantic instead if calendar versioning with the next release. This will allow to declare API compatibility constrains with every release.
References
https://jira.greenbone.net/browse/GEA-876