Skip to content

Commit

Permalink
PLANET-7530: Upgrade to node 18 (#2343)
Browse files Browse the repository at this point in the history
- Update CircleCI config
- Update package*.json
- Add new env var which makes compatibilty with Crypto and Node>17

Co-authored-by: Dan Tovbein <dtovbein@gmail.com>
  • Loading branch information
GP-Dan-Tovbein and dantovbein authored Nov 11, 2024
1 parent 4396f86 commit ad7dfbd
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
10 changes: 5 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:

frontend-tests:
docker:
- image: greenpeaceinternational/p4-unit-tests:node16.19.0
- image: greenpeaceinternational/p4-unit-tests:node18.20.4
auth:
<<: *docker_auth
steps:
Expand All @@ -108,7 +108,7 @@ jobs:

commitlint:
docker:
- image: greenpeaceinternational/p4-unit-tests:node16.19.0
- image: greenpeaceinternational/p4-unit-tests:node18.20.4
auth:
<<: *docker_auth
steps:
Expand All @@ -119,7 +119,7 @@ jobs:

a11y-tests:
docker:
- image: greenpeaceinternational/p4-unit-tests:node16.19.0
- image: greenpeaceinternational/p4-unit-tests:node18.20.4
auth:
<<: *docker_auth
working_directory: /home/circleci/
Expand Down Expand Up @@ -257,7 +257,7 @@ jobs:
create-zip:
docker:
- image: cimg/node:16.19
- image: cimg/node:18.20.4
auth:
<<: *docker_auth
steps:
Expand Down Expand Up @@ -304,7 +304,7 @@ jobs:

publish-zip:
docker:
- image: cimg/node:16.19
- image: cimg/node:18.20.4
auth:
<<: *docker_auth
steps:
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
engine-strict=true
node-options="--openssl-legacy-provider"
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
"react-dom": "^18.2.0"
},
"engines": {
"npm": "<10.0.0",
"node": ">=16.0.0 <17.0.0"
"npm": ">10.0.0 <11.0.0",
"node": ">=18.0.0 <19.0.0"
},
"optionalDependencies": {
"fsevents": "^2.3.2"
Expand Down

0 comments on commit ad7dfbd

Please sign in to comment.