Skip to content

Firmware: Adjust trackpad for Switch Controller #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arxanas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Firmware: Adjust trackpad for Switch Controller #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion Firmware/OpenSteamController/src/trackpad.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,8 +1077,12 @@ void trackpadGetLastXY(Trackpad trackpad, uint16_t* xLoc, uint16_t* yLoc) {
transition_state = POS_INVALID;
}

int32_t max_amplitude_x = 0;

for (int idx = 0; idx < 11; idx++) {
int32_t diff = adc_vals_x[idx+1] - adc_vals_x[idx];
max_amplitude_x = diff > max_amplitude_x ? diff : max_amplitude_x;

if (transition_state == WAIT_FOR_0_TO_P) {
if (diff > 0) {
transition_state = WAIT_FOR_P_TO_N;
Expand Down Expand Up @@ -1129,8 +1133,24 @@ void trackpadGetLastXY(Trackpad trackpad, uint16_t* xLoc, uint16_t* yLoc) {
while (tpadAdcIdxs[trackpad] < NUM_ANYMEAS_ADCS) {
}

// Empirically-determined value. See
// https://github.com/greggersaurus/OpenSteamController/issues/7. This
// can be adjusted if you find that the trackpad is not accurately
// detecting the finger being down.
//
// The relative distance of the finger from the touchpad is determined by
// examining the amplitude of the sine wave. Higher values mean that the
// finger is closer. I got best results at around ~500, so I set this value
// to the closest power of 2.
//
// - If this threshold is too low, then the finger being close to (but not
// touching) the trackpad will register.
// - If this threshold is too high, then only heavier touches will
// register.
const int FINGER_DOWN_REQUIRED_AMPLITUDE = 512;

// Early exit if no finger down detected in X position calculation
if (x_pos < 0) {
if (x_pos < 0 || max_amplitude_x < FINGER_DOWN_REQUIRED_AMPLITUDE) {
return;
}

Expand Down