Open
Conversation
And it shouldn't be supported, even when available at local development environment. As is, the Makefile is trying to use it only to fail, as the docker-compose.yml file isn't supported by the v1 (mainly the variable interpolation).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Welcome to Tron! Thanks for your first pull request.
A maintainer will review it soon. Here's what to expect:
- ✅ Automated tests will run on your changes
- 👀 A maintainer will review your code
- 💬 You may receive feedback or requests for changes
- 🎉 Once approved, your PR will be merged!
While you wait:
- Make sure all tests pass
- Check that your PR follows the contribution guidelines
- Feel free to ask questions if you need help
Thank you for contributing to Tron! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The docker-compose command (docker compose v1) doesn't work upon running
make start.And it shouldn't be supported, even when available at local development environment. As is, the
makecommand is selecting the deprecated docker compose (if available), but the presenteddocker-compose.ymlfile isn't supported by the it (mainly because the variable interpolation).Type of Change
Component Affected