Moment based reffes #1048
Draft
Moment based reffes #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
- Coverage 89.27% 83.60% -5.68%
==========================================
Files 210 228 +18
Lines 26652 27851 +1199
==========================================
- Hits 23793 23284 -509
- Misses 2859 4567 +1708 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In particular, addition/substraction of <:MultiValues is consistent with that of Number and leverages the promotion API made for it.
- Disactivated WIP HHJ stuffs, - `component_basis(::MultiValue)` has been moved in `TensorValues`, optimized and tested - `dual_component_basis_representatives` has been renamed `representatives_of_componentbasis_dual`, has been fixed, optimized and tested - inner product of `SymFourthOrderTensorValue` has been fixed and optimized
[Moment based reffes] merge Gridap 0.19.1
- fixed TensorValues test coverage - better error message for ThirdOrderTensorValue constructor - deprecated `TensorValues.data_index`, it is unused and not general - fix adjoint of `SkewSymTensorValue` - unified summary of TensorValues in TensorValues.md with its docstring, and fixed aliases links
- fixed Conversion with scalar, and SkewSymTensorValue / SMatrix - fixed SkewSymTensorValue 2x2 inverse
[moment-based-reffe] HHJ WIP, SkewSymTensorValue and some TensorValues refactoring
Proposition: small Pushforward API rework for generality and flexibility
- fix `get_order` on BubbleRefFE - Make BubbleRefFE consistent with the `ReferenceFE` API - Better argument checks - more test coverage - documentation and add one missing CellData docstring to fix broken links Changed makedocs argument to error if now undocumented exported symbols are introdued
[Moment based reffes] Fix broken links, BubbleRefFE improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we've been having a look at the current implementation of Raviart-Thomas and Nedelec. It has become clear that the current implementation
Moreover, there has been interest lately in implementing more types of moment-based discretisations like Crouzeix-Raviart.
We believe the best way to solve all these issues at once is to create some extendable machinery to easily create moment-based FEs.
TODOs:
New RefFEs:
Other: Polynomial bases
The solution to the first issue requires extending Jacobi-type polynomial bases. Although it could be done blindly, I think we could try to merge a lot of code together. In the future we might want to have even more basis of polynomials, which would require a lot of copied code.