rpc: fix allow check for ::1 #2797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ClientAllowed check broke in 4d91c8c as the is_v4_compatible function was mistakenly refactored to include ::1 and ::. Since ::1 (a.k.a the IPv6 localhost) got considered to be an IPv4 compatible IPv6 address, it got treated as IPv4 0.0.0.1 which caused the wallet to reject connections from localhost on some systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
curl --data '{"method": "getinfo"}' http://'[::1]':15715/for before and after a91d529.