More precise case import error message #1005
Merged
+43
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
ayolab
approved these changes
Feb 9, 2026
Comment on lines
82
to
85
| export type ErrorMessageDescriptor = { | ||
| descriptor: MessageDescriptor; | ||
| values?: Record<string, PrimitiveType>; | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| export type ErrorMessageDescriptor = { | |
| descriptor: MessageDescriptor; | |
| values?: Record<string, PrimitiveType>; | |
| }; | |
| export type ErrorMessageDescriptor = { | |
| descriptor: Parameters<IntlShape['formatMessage']>[0]; | |
| values?: Parameters<IntlShape['formatMessage']>[1]; | |
| }; |
Maybe like that to be even more precise ? :)
Contributor
Author
There was a problem hiding this comment.
Ok but messageValues from SnackInputs is a :
type FormatValues = Record<string, PrimitiveType | FormatXMLElementFn<string, string>>;
This assignment : https://github.com/gridsuite/commons-ui/pull/1005/changes#diff-3f4e8358f9a84ac3c553c95550bb6dcf620de65fd0ec5f87ab770e52dd549057R55
returns an error. How would you do this cleanly? Shouldn't we use a FormatValues ?
Contributor
There was a problem hiding this comment.
type FormatValues = Parameters<IntlShape['formatMessage']>[1] I guess
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More precise case import error message (coherent with :