module ENR part 2, add powerElectronicsClusters parameters management
#999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…management Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
…_params_part2 Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
|
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
EtienneLt
reviewed
Feb 6, 2026
| isIccMinFeaturesDefaultConfiguration, | ||
| ]); | ||
|
|
||
| const createRows = useCallback(() => { |
Contributor
There was a problem hiding this comment.
is this useCallback needed ? there is no dependencies
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
EtienneLt
reviewed
Feb 6, 2026
| } | ||
| }; | ||
|
|
||
| const parsepowerElectronicsClustersParamString = ( |
Contributor
There was a problem hiding this comment.
Suggested change
| const parsepowerElectronicsClustersParamString = ( | |
| const parsePowerElectronicsClustersParamString = ( |
EtienneLt
reviewed
Feb 6, 2026
| try { | ||
| return JSON.parse(paramString); | ||
| } catch (error) { | ||
| console.error('Error parsing power electronics materials parameter string:', error); |
Contributor
There was a problem hiding this comment.
should the error be managed with snackWithFallback ?
Contributor
Author
There was a problem hiding this comment.
OK but it needs to pass the snackError into the utils functions
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
…om/gridsuite/commons-ui into feat_shortcircuit_ENR_params_part2
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
…ackbar Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary