RabbitMQ messages loadbalancing #222
Conversation
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
klesaulnier
changed the title
klesaulnier
changed the title
| */ | ||
| @Bean | ||
| public ListenerContainerCustomizer<MessageListenerContainer> customizer() { | ||
| AtomicInteger index = new AtomicInteger(); |
There was a problem hiding this comment.
maybe add comment here that we are inspired with the atomicinteger capture by the lambda by spring cloud stream when it sets the consumerTagPrefix of the different consumers of a container
Or at least a comment saying that we expect spring cloud stream to call our customizer (lambda) exactly once in order for each container so it will produce a sequence of increasing priorities
| @Bean | ||
| @Override | ||
| public Consumer<Message<String>> consumeRun() { | ||
| public Consumer<Message<String>> consumeRun1() { |
There was a problem hiding this comment.
comment here to explain the design and why we do it
| consumer: | ||
| concurrency: 4 | ||
| max-attempts: 1 | ||
| consumeRun2-in-0: |
There was a problem hiding this comment.
comment here quickly reexplaining the design and why we do it this way
| quorum: | ||
| enabled: true | ||
| delivery-limit: 2 | ||
| consumeRun2-in-0: |
There was a problem hiding this comment.
another comment here to see the previous one on the design
| cloud: | ||
| function: | ||
| # disable consumeRun2/3/4 during test - all of them receive the "loadflowGroup" messages otherwise | ||
| definition: consumeRun1;consumeCancel |
There was a problem hiding this comment.
HMm that's a shame. It's because of the testbinder instead of rabbitmq binder ? Maybe add more detail explaining this, and why it's good to just disable the other functions, say that the beans are created but not used, etc. Should we add back the concurrency 4 during test also or something else ?
There was a problem hiding this comment.
Checking TestChannelBinderProvisioner.provisionConsumerDestination, ConsumerProperties as well as group seem to be ignored
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
|
2 participants
PR Summary