enable override of 'validity' property for injections and branches (used in estim/adn-in) #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed in estim/adn-in) Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
|
dbraquart
requested changes
Feb 5, 2026
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code: 1 change required
tests: found a test case with a 2WT having no Measurement extension, where I could not create the extension after modification apply.
src/main/java/org/gridsuite/modification/utils/ModificationUtils.java
Outdated
Show resolved
Hide resolved
|
|
||
| private void upsertMeasurement(Measurements<?> measurements, Measurement.Type type, Double value, Boolean validity, List<ReportNode> reports) { | ||
| if (value == null && validity == null) { | ||
| private void upsertMeasurement(Measurements<?> measurements, Measurement.Type type, Double value, Boolean requestedValidity, List<ReportNode> reports) { |
Contributor
There was a problem hiding this comment.
This function is pretty much the same than in BranchModification, except the "Side" ascpect ... hum dont know if it's better with or without a common function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Enable override of 'validity' property for injections and branches (used in estim/adn-in).
estim-intregation uses both 'validity' property and 'valid' boolean from Measurement IIDM extension, to compute the ADN 4-state "valid" attribute in ptm and qtm xml nodes.
Then apply() method should do the same when a modification wants to force the validity of a P/Q TM.