Skip to content

Fix null pointer exception on modification by assignment caused by deleted filters #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basseche wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix null pointer exception on modification by assignment caused by deleted filters #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6482b83
Fix null pointer exception on Modification by assignment caused by de…
basseche Feb 6, 2026
a94bf69
Merge branch 'main' into Fix_NullPointerException_ModificationByAssig…
basseche Feb 6, 2026
c96239c
try add tests
basseche Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...a/org/gridsuite/modification/modifications/byfilter/AbstractModificationByAssignment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
public abstract class AbstractModificationByAssignment extends AbstractModification {
public static final String VALUE_KEY_FILTER_NAME = "filterName";
public static final String VALUE_KEY_FIELD_NAME = "fieldName";
public static final String VALUE_KEY_NAME = "name";
public static final String VALUE_KEY_EQUIPMENT_NAME = "equipmentName";
public static final String VALUE_KEY_EQUIPMENT_TYPE = "equipmentType";
public static final String VALUE_KEY_EQUIPMENT_COUNT = "equipmentCount";
Expand Down Expand Up @@ -299,6 +300,16 @@ private void applyOnFilterEquipments(Network network,
FilterInfos filterInfos) {
FilterEquipments filterEquipments = filterUuidEquipmentsMap.get(filterInfos.getId());

if (filterEquipments == null) {
reports.add(ReportNode.newRootReportNode()
.withResourceBundles(NetworkModificationReportResourceBundle.BASE_NAME)
.withMessageTemplate("network.modification.filterNotFound")
.withUntypedValue(VALUE_KEY_NAME, filterInfos.getName())
.withSeverity(TypedValue.WARN_SEVERITY)
.build());
return;
}

if (CollectionUtils.isEmpty(filterEquipments.getIdentifiableAttributes())) {
reports.add(ReportNode.newRootReportNode()
.withResourceBundles(NetworkModificationReportResourceBundle.BASE_NAME)
Expand Down
10 changes: 9 additions & 1 deletion ...modification/modifications/byfilter/assignment/GeneratorModificationByAssignmentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import com.powsybl.iidm.network.extensions.*;
import org.gridsuite.filter.utils.EquipmentType;
import org.gridsuite.modification.dto.FilterEquipments;
import org.gridsuite.modification.dto.FilterInfos;
import org.gridsuite.modification.dto.IdentifiableAttributes;
import org.gridsuite.modification.dto.ModificationByAssignmentInfos;
import org.gridsuite.modification.dto.byfilter.assignment.AssignmentInfos;
Expand Down Expand Up @@ -301,6 +302,12 @@ protected List<AssignmentInfos<?>> getAssignmentInfos() {
.filters(List.of(filter6))
.build();

DoubleAssignmentInfos assignmentInfos20 = DoubleAssignmentInfos.builder()
.editedField(GeneratorField.Q_PERCENT.name())
.value(120.)
.filters(List.of(new FilterInfos(UUID.randomUUID(), "filterNotFound")))
.build();

List<AssignmentInfos<?>> infosList = super.getAssignmentInfos();
infosList.addAll(List.of(
assignmentInfos1,
Expand All @@ -321,7 +328,8 @@ protected List<AssignmentInfos<?>> getAssignmentInfos() {
assignmentInfos16,
assignmentInfos17,
assignmentInfos18,
assignmentInfos19
assignmentInfos19,
assignmentInfos20
));

return infosList;
Expand Down