TU sensitivity computation with wiremock #925

souissimai · 2026-01-29T13:06:15Z

PR Summary

Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

Mathieu-Deharbe · 2026-01-30T12:13:07Z

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

+        "\"sensitivityInjectionsSet\":[],\"sensitivityInjection\":[],\"sensitivityHVDC\":[],\"sensitivityPST\":[],\"sensitivityNodes\":[]}";
    public static final String SENSITIVITY_ANALYSIS_UPDATED_PARAMETERS_JSON = "{\"flowFlowSensitivityValueThreshold\":90.0,\"angleFlowSensitivityValueThreshold\":0.6,\"flowVoltageSensitivityValueThreshold\":0.1,\"sensitivityInjectionsSet\":[{\"monitoredBranches\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da322\",\"containerName\":\"identifiable2\"}],\"injections\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da321\",\"containerName\":\"identifiable1\"}],\"distributionType\":\"PROPORTIONAL\",\"contingencies\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da323\",\"containerName\":\"identifiable3\"}],\"activated\":true}],\"sensitivityInjection\":[{\"monitoredBranches\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da321\",\"containerName\":\"identifiable1\"}],\"injections\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da322\",\"containerName\":\"identifiable2\"}],\"contingencies\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da323\",\"containerName\":\"identifiable3\"}],\"activated\":true}],\"sensitivityHVDC\":[{\"monitoredBranches\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da321\",\"containerName\":\"identifiable1\"}],\"sensitivityType\":\"DELTA_MW\",\"hvdcs\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da322\",\"containerName\":\"identifiable2\"}],\"contingencies\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da323\",\"containerName\":\"identifiable3\"}],\"activated\":true}],\"sensitivityPST\":[{\"monitoredBranches\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da322\",\"containerName\":\"identifiable2\"}],\"sensitivityType\":\"DELTA_MW\",\"psts\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da321\",\"containerName\":\"identifiable1\"}],\"contingencies\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da323\",\"containerName\":\"identifiable3\"}],\"activated\":true}],\"sensitivityNodes\":[{\"monitoredVoltageLevels\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da321\",\"containerName\":\"identifiable1\"}],\"equipmentsInVoltageRegulation\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da322\",\"containerName\":\"identifiable2\"}],\"contingencies\":[{\"containerId\":\"cf399ef3-7f14-4884-8c82-1c90300da323\",\"containerName\":\"identifiable3\"}],\"activated\":true}]}";

+    private static final String SENSITIVITY_ANALYSIS_PROFILE_PARAMETERS_JSON = "{\"lowVoltageAbsoluteThreshold\":30.0,\"lowVoltageProportionalThreshold\":0.4,\"highVoltageAbsoluteThreshold\":0.0,\"highVoltageProportionalThreshold\":0.0,\"flowProportionalThreshold\":0.1}";


This looks like a copy pasted security analysis parameters json, not a sensitivity analysis parameters json.

It looks like this data is useless and could just be

Suggested change

private static final String SENSITIVITY_ANALYSIS_PROFILE_PARAMETERS_JSON = "{\"lowVoltageAbsoluteThreshold\":30.0,\"lowVoltageProportionalThreshold\":0.4,\"highVoltageAbsoluteThreshold\":0.0,\"highVoltageProportionalThreshold\":0.0,\"flowProportionalThreshold\":0.1}";

private static final String SENSITIVITY_ANALYSIS_PROFILE_PARAMETERS_JSON = "dummy sensitivity analysis parameters";

private static final String SENSITIVITY_ANALYSIS_PROFILE_PARAMETERS_JSON = "{\"flowFlowSensitivityValueThreshold\":30.0,\"voltageVoltageSensitivityValueThreshold\":0.4,\"flowVoltageSensitivityValueThreshold\":0.0,\"angleFlowSensitivityValueThreshold\":0.0}";

I updated it

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>

Mathieu-Deharbe

Sorry for the length of time. I took quite some time to understand the new system well. And so I brought back quite a few extra small things. Do with it what you want.

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

Mathieu-Deharbe · 2026-02-02T12:51:09Z

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

+        // Verify message sent to frontend
        Message<byte[]> message = output.receive(TIMEOUT, STUDY_UPDATE_DESTINATION);
-        assertEquals(studyUuid, message.getHeaders().get(NotificationService.HEADER_STUDY_UUID));
+        assertEquals(studyUuid, message.getHeaders().get(HEADER_STUDY_UUID));
        String updateType = (String) message.getHeaders().get(HEADER_UPDATE_TYPE);
-        assertEquals(NotificationService.UPDATE_TYPE_SENSITIVITY_ANALYSIS_FAILED, updateType);
+        assertEquals(UPDATE_TYPE_SENSITIVITY_ANALYSIS_STATUS, updateType);


This looks like this could be replaced by a call to checkMessagesReceived.

Mathieu-Deharbe · 2026-02-02T12:52:13Z

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

        message = output.receive(TIMEOUT, STUDY_UPDATE_DESTINATION);
-        assertEquals(studyUuid, message.getHeaders().get(NotificationService.HEADER_STUDY_UUID));
+        assertEquals(studyUuid, message.getHeaders().get(HEADER_STUDY_UUID));
        updateType = (String) message.getHeaders().get(HEADER_UPDATE_TYPE);
-        assertEquals(NotificationService.UPDATE_TYPE_SENSITIVITY_ANALYSIS_STATUS, updateType);
+        assertEquals(UPDATE_TYPE_SENSITIVITY_ANALYSIS_FAILED, updateType);


This too looks like it could be replaced by a call to checkMessagesReceived.

Mathieu-Deharbe · 2026-02-02T12:54:21Z

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

        message = output.receive(TIMEOUT, STUDY_UPDATE_DESTINATION);
-        assertEquals(studyUuid2, message.getHeaders().get(NotificationService.HEADER_STUDY_UUID));
+        assertEquals(studyUuid2, message.getHeaders().get(HEADER_STUDY_UUID));
        updateType = (String) message.getHeaders().get(HEADER_UPDATE_TYPE);
-        assertEquals(NotificationService.UPDATE_TYPE_SENSITIVITY_ANALYSIS_STATUS, updateType);
-
-        assertTrue(TestUtils.getRequestsDone(1, server).stream().anyMatch(r -> r.matches("/v1/networks/" + NETWORK_UUID_3_STRING + "/run-and-save.*?receiver=.*nodeUuid.*")));
-    }
-
-    private StudyEntity insertDummyStudy(UUID networkUuid, UUID caseUuid, UUID sensitivityAnalysisParametersUuid) {
-        StudyEntity studyEntity = TestUtils.createDummyStudy(networkUuid, "netId", caseUuid, "", "", null, UUID.randomUUID(), null, null, sensitivityAnalysisParametersUuid, null, null);
-        var study = studyRepository.save(studyEntity);
-        networkModificationTreeService.createRoot(studyEntity);
-        return study;
-    }
+        assertEquals(UPDATE_TYPE_SENSITIVITY_ANALYSIS_STATUS, updateType);


This too looks like it could be replaced by a call to checkMessagesReceived.

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

Mathieu-Deharbe · 2026-02-02T12:58:55Z

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

+        Message<byte[]> message = output.receive(TIMEOUT, STUDY_UPDATE_DESTINATION);
+        assertEquals(studyUuid, message.getHeaders().get(HEADER_STUDY_UUID));
+        assertEquals(UPDATE_TYPE_SENSITIVITY_ANALYSIS_STATUS, message.getHeaders().get(HEADER_UPDATE_TYPE));


This too looks like it could be replaced by a call to checkMessagesReceived.

Mathieu-Deharbe · 2026-02-02T12:59:03Z

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

+        message = output.receive(TIMEOUT, STUDY_UPDATE_DESTINATION);
+        assertEquals(studyUuid, message.getHeaders().get(HEADER_STUDY_UUID));
+        assertEquals(UPDATE_TYPE_COMPUTATION_PARAMETERS, message.getHeaders().get(HEADER_UPDATE_TYPE));


This too looks like it could be replaced by a call to checkMessagesReceived.

Mathieu-Deharbe · 2026-02-02T14:08:02Z

src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java

+        // run-and-save called
+        wireMockServer.verify(postRequestedFor(
+            urlPathMatching("/v1/networks/" + NETWORK_UUID_STRING + "/run-and-save.*"))
+            .withQueryParam("reportType", equalTo("SensitivityAnalysis"))


Ok this is longer. Do as you wish.

Suggested change

.withQueryParam("reportType", equalTo("SensitivityAnalysis"))

.withQueryParam("reportType", equalTo(SENSITIVITY_ANALYSIS.reportKey))

Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>

sonarqubecloud · 2026-02-03T13:47:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SOUISSI Maissa (Externe) and others added 2 commits January 29, 2026 14:05

TU sensitivity computation with wiremock

0b4ef67

Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>

Merge branch 'main' into TU_sensitivity

49c0d2d

Mathieu-Deharbe self-requested a review January 30, 2026 11:22

Mathieu-Deharbe reviewed Jan 30, 2026

View reviewed changes

souissimai and others added 2 commits February 2, 2026 10:48

Merge branch 'main' into TU_sensitivity

6c1306e

fix

c458720

Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>

Mathieu-Deharbe approved these changes Feb 2, 2026

View reviewed changes

souissimai and others added 2 commits February 3, 2026 14:29

Merge branch 'main' into TU_sensitivity

7a5e21c

fixes

7e849d6

Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>

souissimai merged commit 46931e9 into main Feb 3, 2026
3 checks passed

souissimai deleted the TU_sensitivity branch February 3, 2026 16:03

	private static final String SENSITIVITY_ANALYSIS_PROFILE_PARAMETERS_JSON = "{\"lowVoltageAbsoluteThreshold\":30.0,\"lowVoltageProportionalThreshold\":0.4,\"highVoltageAbsoluteThreshold\":0.0,\"highVoltageProportionalThreshold\":0.0,\"flowProportionalThreshold\":0.1}";
	private static final String SENSITIVITY_ANALYSIS_PROFILE_PARAMETERS_JSON = "dummy sensitivity analysis parameters";

	.withQueryParam("reportType", equalTo("SensitivityAnalysis"))
	.withQueryParam("reportType", equalTo(SENSITIVITY_ANALYSIS.reportKey))

TU sensitivity computation with wiremock #925

TU sensitivity computation with wiremock #925

Uh oh!

Conversation

souissimai commented Jan 29, 2026

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mathieu-Deharbe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 3, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants