Merge pull request #1097 from griffithlab/improve-submission-comment-…

…display Improve Submission Comment display when no comment exists
griffithlab · Aug 20, 2024 · 27e8c3b · 27e8c3b
2 parents e3bd1ba + f2704ce
commit 27e8c3b
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 10 deletions.
diff --git a/client/src/app/components/activities/activity-feed/activity-feed.component.html b/client/src/app/components/activities/activity-feed/activity-feed.component.html
@@ -29,8 +29,7 @@
             {{ activity.verbiage }}
             @switch (activity.subject.__typename) {
               @case ('Feature') {
-                <cvc-feature-tag
-                  [feature]="activity.subject"></cvc-feature-tag>
+                <cvc-feature-tag [feature]="activity.subject"></cvc-feature-tag>
               }
               @case ('Assertion') {
                 <cvc-assertion-tag

diff --git a/client/src/app/components/comments/comment-display/comment-display.component.html b/client/src/app/components/comments/comment-display/comment-display.component.html
@@ -11,7 +11,15 @@
       nzIcon="civic:curator"></nz-avatar>
   </ng-template>
   <nz-comment-content>
-    <cvc-comment-body
-      [commentBodySegments]="comment.parsedComment"></cvc-comment-body>
+    @if (comment.parsedComment.length == 0) {
+      <span
+        nz-typography
+        nzType="secondary">
+        <i>No Comment Provided</i>
+      </span>
+    } @else {
+      <cvc-comment-body
+        [commentBodySegments]="comment.parsedComment"></cvc-comment-body>
+    }
   </nz-comment-content>
 </nz-comment>
diff --git a/client/src/app/components/comments/comment-display/comment-display.component.ts b/client/src/app/components/comments/comment-display/comment-display.component.ts
@@ -1,14 +1,14 @@
 import { Component, Input, OnInit } from '@angular/core'
-import { Comment, CommentBodySegment, Maybe, Scalars } from '@app/generated/civic.apollo'
+import { CommentBodySegment, Maybe } from '@app/generated/civic.apollo'
 
 export interface CommenterInterface {
-  displayName: string,
+  displayName: string
   profileImagePath: Maybe<string>
 }
 
-export interface CommentInterface  {
-  createdAt: string | number,
-  parsedComment: CommentBodySegment[],
+export interface CommentInterface {
+  createdAt: string | number
+  parsedComment: CommentBodySegment[]
   commenter: CommenterInterface
 }
 

diff --git a/client/src/app/components/comments/comment-display/comment-display.module.ts b/client/src/app/components/comments/comment-display/comment-display.module.ts
@@ -5,15 +5,17 @@ import { NzCommentModule } from 'ng-zorro-antd/comment'
 import { NzAvatarModule } from 'ng-zorro-antd/avatar'
 import { CvcCommentBodyModule } from '../comment-body/comment-body.module'
 import { CvcPipesModule } from '@app/core/pipes/pipes.module'
+import { NzTypographyModule } from 'ng-zorro-antd/typography'
 
 @NgModule({
   declarations: [CvcCommentDisplayComponent],
   imports: [
     CommonModule,
     NzCommentModule,
     NzAvatarModule,
+    NzTypographyModule,
     CvcCommentBodyModule,
-    CvcPipesModule
+    CvcPipesModule,
   ],
   exports: [CvcCommentDisplayComponent],
 })