Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Curation Timelines from Events to Activities #1136

Merged
merged 151 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
151 commits
Select commit Hold shift + click to select a range
80d816d
replaced old activity-feed component
jmcmichael Jan 16, 2024
d6152f4
set up parameters, filters, fetch/refetch observables, queries
jmcmichael Jan 18, 2024
3364fcd
feedPrefs Inputs working with OnChanges & refetch query
jmcmichael Jan 18, 2024
bb02dc9
feedInfo Output working
jmcmichael Jan 18, 2024
88e2178
activity-item component boilerplate
jmcmichael Jan 18, 2024
0cd0ee6
all setting, filters inputs working w/ queries
jmcmichael Jan 19, 2024
fe1b402
implemented as nz-list with nzGrid layout
jmcmichael Jan 22, 2024
807b992
feed settings, filters, counts components working
jmcmichael Jan 24, 2024
2b24580
Merge branch 'main' into merge-filters
jmcmichael Jan 24, 2024
467f139
Merge remote-tracking branch 'origin/activity-feed-filters' into merg…
jmcmichael Jan 24, 2024
4ecb71f
componentized feed-settings
jmcmichael Jan 25, 2024
bffdcfd
updated ng 17.0.0 -> 17.1.1
jmcmichael Jan 25, 2024
c001189
Merge branch 'main' into activity-feed-v2
jmcmichael Jan 31, 2024
999063e
componentized activity-feed card
jmcmichael Feb 1, 2024
f7c072f
subscribable subject filter working
jmcmichael Feb 1, 2024
b3b69ab
filter lists display layout working
jmcmichael Feb 1, 2024
594d6c3
filter select, clear, 'show all' option working
jmcmichael Feb 1, 2024
c26a623
Merge remote-tracking branch 'origin/activity-feed-filters' into acti…
jmcmichael Feb 7, 2024
f7dc6f6
Merge remote-tracking branch 'origin/activity-feed-filters' into acti…
jmcmichael Feb 7, 2024
4f5b819
Merge remote-tracking branch 'origin/activity-feed-filters' into acti…
jmcmichael Feb 7, 2024
380c512
Merge remote-tracking branch 'origin/activity-feed-filters' into acti…
jmcmichael Feb 7, 2024
7858ba9
regenerated apollo client from updated server schema
jmcmichael Feb 13, 2024
3738793
refactor feed for activities() query & better component architecture
jmcmichael Feb 13, 2024
57b5d7f
activity-feed -> settings/filters defaults & update flow working better
jmcmichael Feb 14, 2024
c13cd3a
activity-feed query, draft feed-item row working
jmcmichael Feb 14, 2024
53ffb6f
componentized activity-feed-item
jmcmichael Feb 15, 2024
2f9e9f8
activity-feed-item showDetails toggle/query working
jmcmichael Feb 15, 2024
d3de228
activity-feed-item showDetails toggle/query working
jmcmichael Feb 15, 2024
1e811cf
settings defaults & ui updates working
jmcmichael Feb 15, 2024
31ae8fc
feed scope working with query mode & id params
jmcmichael Feb 15, 2024
fb3f8d2
Merge branch 'activity-feed-v2--query-mode' into activity-feed-v2
jmcmichael Feb 15, 2024
474408c
feed-filter selects populating from response filter options
jmcmichael Feb 15, 2024
b8388e3
feed-filters working with activities query
jmcmichael Feb 15, 2024
0c4520b
added Source to SubscribableEntities
jmcmichael Feb 16, 2024
a0ec241
Subject Types filter displays entity icons in option labels
jmcmichael Feb 16, 2024
bb6a4a9
activity type filter options include relevant civic icon
jmcmichael Feb 16, 2024
b1cf1b4
selected filter tags include icon
jmcmichael Feb 17, 2024
dcf8259
feed-counts working with ActivityFeedCounts input
jmcmichael Feb 17, 2024
40312b7
added config for Activities relay style pagination
jmcmichael Feb 17, 2024
9620218
improved activity-feed/feed-item queries, use of signals
jmcmichael Feb 17, 2024
b9c730a
simpler signal-based toggle
jmcmichael Feb 17, 2024
c41db82
improved feed & feed-item query structure, added 'requestDetails' option
jmcmichael Feb 18, 2024
9016eb0
updated angular-apollo, angular-client
jmcmichael Feb 18, 2024
046ff62
refactored feed gql so that feed connection fields identical to detai…
jmcmichael Feb 19, 2024
e8b8e24
refactored feed gql so that feed connection fields identical to detai…
jmcmichael Feb 19, 2024
d66f43c
upgraded apollo-angular, dependencies
jmcmichael Feb 20, 2024
b37b8dd
Merge branch 'activity-feed-v2--upgrade-apollo' into activity-feed-v2
jmcmichael Feb 20, 2024
e7d0dc4
simpler/quicker item initial display & detail query update method
jmcmichael Feb 20, 2024
5bdb9aa
simpler/quicker item initial display & detail query update method
jmcmichael Feb 20, 2024
a00fdd1
activity-feed auto-height working
jmcmichael Feb 20, 2024
67c45cb
basic infinite-scroll working
jmcmichael Feb 20, 2024
fa30186
moved some utility functions to activity-feed.functions
jmcmichael Feb 21, 2024
120ae90
ngx-ui-scroll fetchMore working properly
jmcmichael Feb 21, 2024
8e9ff29
feed item counts, scroller reset on filter refetch query
jmcmichael Feb 22, 2024
ae40b7a
Merge branch 'activity-feed-v2--infinite-scroll' into activity-feed-v2
jmcmichael Feb 22, 2024
eb38c5b
switched to using nz-card for feed-items, added tags to item titles
jmcmichael Feb 22, 2024
1ed326c
added loading refetch/fetchMore indicators to feed
jmcmichael Feb 22, 2024
0d459ec
added details components for each activity type
jmcmichael Feb 22, 2024
310553f
each activity type has its own details component
jmcmichael Feb 27, 2024
afbecf9
ActivityFeedItemFragment typeguards working in activity-item-detail
jmcmichael Mar 1, 2024
c35b68a
simplified activity-feed directory structure, component names
jmcmichael Mar 1, 2024
6545f0f
created detail fragments, type guards for all feed-item detail compon…
jmcmichael Mar 4, 2024
546db2f
moved activity detail query to feed-item-details from feed-item
jmcmichael Mar 6, 2024
5ff9418
all activity detail components working w/ detail query, guards, etc.
jmcmichael Mar 6, 2024
435bb48
activity-feed keeps track of toggled items for virt-scroll reinstanti…
jmcmichael Mar 6, 2024
5e8ee7d
adjusted scroller settings for smoother scrolling
jmcmichael Mar 7, 2024
cb47627
Merge remote-tracking branch 'origin/main' into activity-feed-v2--mer…
jmcmichael Mar 7, 2024
fbb6fd0
add option to exclude civicbot events
acoffman Mar 7, 2024
9e0f997
activity-feed 'user' mode working
jmcmichael Mar 7, 2024
439fa92
activity-feed 'subject' mode working
jmcmichael Mar 7, 2024
1e5d913
activity-feed 'organization' mode working
jmcmichael Mar 7, 2024
acc4665
includeAutomatedEvents setting/default working
jmcmichael Mar 7, 2024
a76896a
rewrote feed-item-details template w/o guardType pipe
jmcmichael Mar 7, 2024
c32efa4
implemented error, null results, end-of-results notifications
jmcmichael Mar 8, 2024
528d951
implemented activity() loading state in feed detail area
jmcmichael Mar 8, 2024
af6e1c5
implemented activity() loading state in feed detail area
jmcmichael Mar 8, 2024
bf95c2c
result$ catches all HTTP & GQL errors
jmcmichael Mar 14, 2024
26b08ad
added onError Apollo link to catch and log all network, gql errs
jmcmichael Mar 15, 2024
0c19c10
unified init, refetch, fetchMore query streams
jmcmichael Mar 15, 2024
e1d5111
created feed-scroll-service to suppress tag popovers
jmcmichael Mar 16, 2024
8761433
updated ui-scroller, using better scroll event source
jmcmichael Mar 19, 2024
f6f5684
feed-scroll.service's isScrolling signal working properly
jmcmichael Mar 20, 2024
2c4a474
implemented bottom/top of scroller notifications
jmcmichael Mar 20, 2024
e84ce6c
Merge branch 'activity-feed-v2--scroller-notifications--query-errs' i…
jmcmichael Mar 21, 2024
739f3dd
activity-feed modularized, able to share singleton scroller event ser…
jmcmichael Mar 21, 2024
a710d45
Merge branch 'activity-feed-v2' into main--merge-activity-feed
jmcmichael Aug 28, 2024
b91406b
fixed incorrect subject_input_type merge
jmcmichael Aug 28, 2024
dd7e5c0
fixed gene reference in icon-name-for-activity-type pipe
jmcmichael Aug 28, 2024
383b772
scroller service configuration working
jmcmichael Aug 29, 2024
a594241
converted activity-feed to standalone component
jmcmichael Aug 29, 2024
547a175
shared scrollState service works for all child components
jmcmichael Aug 29, 2024
59b18ce
feed-scroll service's toggledItems model working
jmcmichael Sep 3, 2024
a5c6466
toggled items rendering properly with vscroll's virtualization
jmcmichael Sep 3, 2024
2439f3c
initial stab at comment-only activity details
acoffman Sep 3, 2024
9aa9e28
fix typo in error message
acoffman Sep 4, 2024
9da6210
add detail queries for all activities, add deprecate feature activity
acoffman Sep 4, 2024
6a2b566
added config for Apollo GraphQL VSCode extension
jmcmichael Sep 6, 2024
acd8182
removed old client model gql
jmcmichael Sep 6, 2024
18c81a5
date-range filter working
jmcmichael Sep 6, 2024
371ebe8
fixed occured -> occurred
jmcmichael Sep 7, 2024
ea664b2
switched to dual After/Before fields
jmcmichael Sep 7, 2024
924c67c
filter's select item icons are properly specified, colored
jmcmichael Sep 8, 2024
9fcec04
added vscode chrome launch configuration
jmcmichael Sep 8, 2024
44c2750
filter select's user, organization tag icons colored properly
jmcmichael Sep 8, 2024
025d8dc
factor, gene variant tags working in feed-item
jmcmichael Sep 9, 2024
6ba0186
updated activity item verbiage to remove subject names
jmcmichael Sep 9, 2024
38117a2
fixed scroller page request issue w/ requested rows > returned rows
jmcmichael Sep 9, 2024
ef0e12a
created overlay to hold status messages, implemented no results msg
jmcmichael Sep 10, 2024
493399a
date selectors can only select valid dates (e.g. no future date for '…
jmcmichael Sep 10, 2024
0174559
added atTop/Bottom to state service
jmcmichael Sep 10, 2024
edf23d0
empty results msg working
jmcmichael Sep 10, 2024
46aaef2
feed-items now expand to full height of details content
jmcmichael Sep 10, 2024
96016c8
revisions detail component works with ObjectFieldDiffs
jmcmichael Sep 11, 2024
8913826
activity-revision scalar field diffs working
jmcmichael Sep 11, 2024
af9d3fb
suggest-revision-activity detail done
jmcmichael Sep 11, 2024
062b68c
fixed flex-wrap issues
jmcmichael Sep 11, 2024
913b6fc
fixed flex-wrap issues
jmcmichael Sep 11, 2024
42c6630
styled comment-only details components
jmcmichael Sep 12, 2024
e8a3016
complex activity type details complete (with simple placeholder tags)
jmcmichael Sep 12, 2024
0fb58d2
Merge branch 'activity-feed-v3--revision-activity-details' into activ…
jmcmichael Sep 12, 2024
67d85ce
cleared preset activityType from feed config
jmcmichael Sep 12, 2024
9cf2a88
CvcActivityFeedComponent -> CvcActivityFeed
jmcmichael Sep 12, 2024
e1c788e
fixed missing scope from initial queries
jmcmichael Sep 12, 2024
504f800
subject, organization, user scoped feeds working
jmcmichael Sep 12, 2024
e6a7412
applied fix for OrganizationMembers query AmbiguousColumn error
jmcmichael Sep 13, 2024
923164e
scroller get() fn properly returns rows after fetching all items
jmcmichael Sep 14, 2024
f80918f
scroller get() fn properly returns rows after fetching all items
jmcmichael Sep 14, 2024
f790606
feed activity, subject options sorted by alphabetical order
jmcmichael Sep 16, 2024
964e0eb
homepage news & feed blocks auto-set same height to fit available space
jmcmichael Sep 16, 2024
482f1bf
filter column border & padding fixed in hidden filters state
jmcmichael Sep 16, 2024
717c2f4
fixed scroller get() logic for subject feeds w/ low activity counts
jmcmichael Sep 16, 2024
8e4d2f4
Merge branch 'activity-feed-v3--fix-get-logic' into activity-feed-v3
jmcmichael Sep 16, 2024
c3dea1b
Merge branch 'main' into activity-feed-v3
acoffman Sep 17, 2024
6d3b05d
add fusion variant to feed
acoffman Sep 17, 2024
caf8e50
pull back fusion variant info
acoffman Sep 17, 2024
0c029df
add comment to case statement
acoffman Sep 17, 2024
0cc4506
Merge branch 'main' into activity-feed-v3
jmcmichael Oct 3, 2024
7745269
fixed apollo config
jmcmichael Oct 9, 2024
2994711
refactored tags' enablePover feature to toggle nzPopoverContent; remo…
jmcmichael Oct 9, 2024
132a846
added enablePopover attributes to browse table tags
jmcmichael Oct 9, 2024
6c25a7a
feed update query & notification/button working
jmcmichael Oct 10, 2024
bee5751
moved activities notification to feed-filters component
jmcmichael Oct 14, 2024
8fd2e31
added sorting to feed-filters
jmcmichael Oct 14, 2024
9de8cf5
fixed participating user filter query var munging
jmcmichael Oct 16, 2024
5cc8fd9
feed-details now handles DeleteCommentActivity type
jmcmichael Oct 16, 2024
36b2b4b
improved toggle display for items w/o details
jmcmichael Oct 16, 2024
85c186a
added 'no note provided' msg for comment-only activity details
jmcmichael Oct 16, 2024
8b2bc1d
comment & delete comment activities now show both comment & subject i…
jmcmichael Oct 17, 2024
0dc12e8
fixed empty results messages
jmcmichael Oct 17, 2024
ba9f0e0
fixed sorted query, removed Sort By select
jmcmichael Oct 18, 2024
3f4fa44
Merge branch 'main' into activity-feed-v3
jmcmichael Oct 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions client/.editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ root = true

[*]
charset = utf-8
tab_width = 2
indent_style = space
indent_size = 2
indent_size = tab
insert_final_newline = true
trim_trailing_whitespace = true

Expand All @@ -17,8 +18,5 @@ trim_trailing_whitespace = false

[*.less]
quote_type = double
charset = utf-8
indent_style = space
indent_size = 2
insert_final_newline = true
trim_trailing_whitespace = true
1 change: 1 addition & 0 deletions client/.graphqlrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ extensions:
- fragment-matcher
config:
apolloClientVersion: 3
useExplicitTyping: false
./src/app/generated/civic.apollo-helpers.ts:
plugins:
- typescript-apollo-client-helpers
Expand Down
15 changes: 15 additions & 0 deletions client/.vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "chrome",
"request": "launch",
"name": "Launch Chrome against CIViC Dev",
"url": "http://127.0.0.1:4200",
"webRoot": "${workspaceFolder}"
}
]
}
9 changes: 9 additions & 0 deletions client/apollo.config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"client": {
"service": {
// can be a string pointing to a single file or an array of strings
"localSchemaFile": "./src/app/generated/server.model.graphql"
},
"excludes": ["./src/app/generated/*.ts", "./src/app/generated/*.json"]
}
}
2 changes: 2 additions & 0 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@
"rxjs-spy": "^8.0.2",
"ts-enum-util": "^4.0.2",
"ts-mixin-extended": "^1.1.1",
"vscroll": "1.6.1",
"ngx-ui-scroll": "3.2.0",
"zone.js": "0.14.3"
},
"devDependencies": {
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading